-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Load a wiki page after Selenium is initialized to remind the user to look back at the terminal to answer more questions #242
Conversation
…o look back at the terminal to answer more questions.
thanks for getting the ball rolling on this! i've been meaning to make this change for a few weeks but didn't get around to it. after some more thought, i think it would be better to load a local HTML page rather than loading a page hosted in the wiki - a) because it means the page should load instantly, and b) because it doesn't really belong in the wiki. would you mind taking a look at whether it's possible to point selenium at a local HTML file? you may also need to update the pyinstaller build to include the new file |
Surely, if you want to go even further it could be a localhost webserver and move the config from terminal into a UI? That might be too much though :) |
I split the difference, it's setup on an internal web server but just a single static page for now. |
Is the test failure real? Seems unrelated in the PDF functionality and those tests haven't been run in a while. I can look tomorrow or something. |
we certainly could do yea - though i think it's out of scope here. let's roll with the local webserver approach you have for now and come back to reworking the UI later
it looks like this is because you haven't set up your repo fork with google drive credentials. this is touched on here https://github.com/chilli-axe/mpc-autofill/wiki#contributing but it looks like the docs are a bit out of date - this now matters when modifying desktop tool code as well as backed code. i'll update the docs in a sec to clarify this the tests failing isn't a big deal at all, they'll rerun with my google drive credentials after i merge the PR anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending my one comment, thanks for this PR!
Path(__file__).joinpath("../..").joinpath(constants.POST_LAUNCH_HTML_FILENAME).resolve().read_bytes() | ||
) | ||
|
||
def log_request(self, code: int | str = "-", size: int | str = "-") -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to maintain compatibility with windows 7 for as long as possible, we're still on python 3.9 - so you'll need to use old-style typing here:
def log_request(self, code: int | str = "-", size: int | str = "-") -> None: | |
def log_request(self, code: Union[int, str] = "-", size: Union[int, str] = "-") -> None: |
merging w/ unresolved comment, i'll fix this bit up |
Description
I set the page to
Desktop-Tool-Landing
but it can be whatever. Some example content (because wikis don't accept PRs):Checklist
pre-commit
and installed the hooks withpre-commit install
before creating any commits.