Feature/image-uploader #22
Conversation
❌ Deploy Preview for tranquil-zabaione-349a68 failed.
|
fmtabbara
force-pushed
the
feature/setup-shadcn
branch
2 times, most recently
from
9e40036 to
29ef418
Compare
fmtabbara
force-pushed
the
feature/setup-shadcn
branch
from
4da25a2 to
1a90673
Compare
… and update related logic
There was a problem hiding this comment.
I think merging was not handled here properly.
There was a problem hiding this comment.
It's correct. The login and register were moved out of the page into a component. The pagewrapper may not be necessary as we have your theme wrapper
There was a problem hiding this comment.
image was provided as parameter it should have been remove as we are using imageURL
There was a problem hiding this comment.
I didnt want to break the app so I left it for the time being. Let's make the swap in separate piece of work.
There was a problem hiding this comment.
I think landing and signup, signup page will not have header same as create event so we should move forward to their respective page
There was a problem hiding this comment.
OK. Let's h handle this in a separate piece of work
There was a problem hiding this comment.
It was as per UI. Here we are not using shadcn. For basic components we should avoid right ?
I used shadcn for popover or tooltip.
There was a problem hiding this comment.
shadcn provides base components. We should be able to style them in the same way as the design.
Base functionality - UI will need to be worked on separately