Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ffi and install.libs.R #290

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

GabrielHoffman
Copy link
Contributor

I'm writing a R package with an Rcpp package, and I'd like to access the plink code at the C++ level. You made some small changes before based on this (#283), and here I make two small changes so C++ code in other packages can access plink code at compile time.

  1. Modify Makevars.in to include pvar_ffi_support.o and pgenlib_ffi_support.o in libPLINK2.a

  2. Add install.libs.R to put static libraries in the default install path, so C++ in other packages can link against them.

In testing, this works on OSX and linux

@chrchang chrchang merged commit 953408c into chrchang:master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants