Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing a R package with an Rcpp package, and I'd like to access the plink code at the C++ level. You made some small changes before based on this (#283), and here I make two small changes so C++ code in other packages can access plink code at compile time.
Modify
Makevars.in
to includepvar_ffi_support.o
andpgenlib_ffi_support.o
inlibPLINK2.a
Add
install.libs.R
to put static libraries in the default install path, so C++ in other packages can link against them.In testing, this works on OSX and linux