Recorder: rephrase failure cases

chris-araman · Aug 7, 2021 · 9329e04 · 9329e04
1 parent 58634da
commit 9329e04
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/Tests/CombineCloudKitTests/Simulation/Recorder.swift b/Tests/CombineCloudKitTests/Simulation/Recorder.swift
@@ -20,6 +20,7 @@ class Recorder<P>: Subscriber where P: Publisher {
   public let finished = XCTestExpectation()
 
   init(_ publisher: P) {
+    finished.assertForOverFulfill = true
     publisher.receive(subscriber: self)
   }
 
@@ -33,19 +34,17 @@ class Recorder<P>: Subscriber where P: Publisher {
   }
 
   func receive(_ input: Input) -> Subscribers.Demand {
-    guard completion == nil else {
+    if completion != nil {
       XCTFail("Element received after completion.")
-      return .unlimited
     }
 
     elements.append(input)
     return .unlimited
   }
 
   func receive(completion: Subscribers.Completion<Failure>) {
-    guard self.completion == nil else {
+    if self.completion != nil {
       XCTFail("Another completion received after initial completion.")
-      return
     }
 
     self.completion = completion