Adjust for Windows Python 3.12 causing lots of unused parameter warni…

…ngs where the suppression doesn't work.
christofmuc · Jan 4, 2025 · c5d6d94 · c5d6d94
1 parent 5b596a3
commit c5d6d94
Show file tree

Hide file tree

Showing 15 changed files with 83 additions and 5 deletions.
diff --git a/MidiKraft b/MidiKraft
diff --git a/The-Orm/BCR2000_Component.cpp b/The-Orm/BCR2000_Component.cpp
@@ -366,7 +366,7 @@ void BCR2000_Component::UpdateSynthListener::listenForMidiMessages(MidiInput* so
 			if (programChangeCap) {
 				programChangeCap->gotProgramChange(MidiProgramNumber::fromZeroBase(message.getProgramChangeNumber()));
 				if (location) {
-					auto patch = midikraft::awaitMidiCoroutine(papa_->librarian_.downloadEditBuffer(midikraft::MidiController::instance()->getMidiOutput(location->midiOutput()), UIModel::currentSynthOfPatchSmart(), nullptr));
+					auto patch = midikraft::awaitMidiCoroutine(papa_->librarian_.downloadEditBuffer(midikraft::MidiController::instance()->getMidiOutput(location->midiOutput()), UIModel::currentSynthOfPatchSmart(), nullptr, {}));
 					if (patch.size() > 0 && patch[0].patch()) {
 						updateAllKnobsFromPatch(patch[0].patch());
 					}

diff --git a/The-Orm/PatchView.cpp b/The-Orm/PatchView.cpp
@@ -579,7 +579,7 @@ void PatchView::retrieveEditBuffer()
 	auto midiLocation = midikraft::Capability::hasCapability<midikraft::MidiLocationCapability>(activeSynth);
 	if (activeSynth && midiLocation) {
 		midikraft::runMidiCoroutineWithCallback < std::vector<midikraft::PatchHolder>>(
-			librarian_.downloadEditBuffer(midikraft::MidiController::instance()->getMidiOutput(midiLocation->midiOutput()), activeSynth, nullptr),
+			librarian_.downloadEditBuffer(midikraft::MidiController::instance()->getMidiOutput(midiLocation->midiOutput()), activeSynth, nullptr, {}),
 			[this](std::vector<midikraft::PatchHolder> const& patchesLoaded) {
 				// There should only be one edit buffer, just check that this is true here
 				jassert(patchesLoaded.size() == 1);

diff --git a/The-Orm/ScriptedQuery.cpp b/The-Orm/ScriptedQuery.cpp
@@ -11,8 +11,15 @@
 
 #include "Logger.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/embed.h>
 #include <spdlog/spdlog.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 namespace py = pybind11;
 using namespace pybind11::literals;

diff --git a/adaptations/GenericAdaptation.cpp b/adaptations/GenericAdaptation.cpp
@@ -20,7 +20,14 @@
 #include "GenericHasBanksCapability.h"
 #include "GenericHasBankDescriptorsCapability.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/stl.h>
+#ifdef _MSC_VER
+#pragma warning ( pop )
+#endif
 #include <memory>
 #include <spdlog/spdlog.h>
 #include "SpdLogJuce.h"

diff --git a/adaptations/GenericAdaptation.h b/adaptations/GenericAdaptation.h
@@ -15,7 +15,14 @@
 #include "ProgramDumpCapability.h"
 #include "BankDumpCapability.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/embed.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 #include <fmt/format.h>
 #include <spdlog/spdlog.h>
 

diff --git a/adaptations/GenericBankDumpCapability.cpp b/adaptations/GenericBankDumpCapability.cpp
@@ -8,8 +8,15 @@
 
 #include "Sysex.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/embed.h>
 #include <pybind11/stl.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 #include <fmt/format.h>
 #include <spdlog/spdlog.h>

diff --git a/adaptations/GenericEditBufferCapability.cpp b/adaptations/GenericEditBufferCapability.cpp
@@ -11,8 +11,15 @@
 
 #include "GenericPatch.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/embed.h>
 #include <pybind11/stl.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 namespace py = pybind11;
 

diff --git a/adaptations/GenericHasBankDescriptorsCapability.cpp b/adaptations/GenericHasBankDescriptorsCapability.cpp
@@ -9,8 +9,15 @@
 #include "GenericAdaptation.h"
 #include "Sysex.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/embed.h>
 #include <pybind11/stl.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 namespace py = pybind11;
 

diff --git a/adaptations/GenericHasBanksCapability.cpp b/adaptations/GenericHasBanksCapability.cpp
@@ -9,7 +9,14 @@
 #include "GenericAdaptation.h"
 #include "Sysex.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/embed.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 namespace py = pybind11;
 

diff --git a/adaptations/GenericPatch.cpp b/adaptations/GenericPatch.cpp
@@ -8,8 +8,14 @@
 
 #include "GenericAdaptation.h"
 
-#include <pybind11/embed.h>
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/stl.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 namespace py = pybind11;
 

diff --git a/adaptations/GenericPatch.h b/adaptations/GenericPatch.h
@@ -15,7 +15,14 @@
 #include "LayeredPatchCapability.h"
 #include "StoredTagCapability.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/embed.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 #include <fmt/format.h>
 #include <spdlog/spdlog.h>

diff --git a/adaptations/GenericProgramDumpCapability.cpp b/adaptations/GenericProgramDumpCapability.cpp
@@ -10,8 +10,15 @@
 
 #include "Sysex.h"
 
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/embed.h>
 #include <pybind11/stl.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 namespace py = pybind11;
 

diff --git a/adaptations/PythonUtils.h b/adaptations/PythonUtils.h
@@ -7,7 +7,16 @@
 #pragma once
 
 #include <string>
+
+#ifdef _MSC_VER
+#pragma warning ( push )
+#pragma warning ( disable: 4100 )
+#endif
 #include <pybind11/pybind11.h>
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
+
 
 class PyStdErrOutStreamRedirect {
 public:

diff --git a/pytschirp b/pytschirp
+1 −1		base/CMakeLists.txt
+9 −2		base/include/BankDumpCapability.h
+1 −2		base/include/DiscoverableDevice.h
+3 −0		base/include/LayeredPatchCapability.h
+1 −1		base/include/MTSFile.h
+9 −0		base/include/MidiController.h
+2 −0		base/include/Patch.h
+1 −1		base/include/SimpleDiscoverableDevice.h
+1 −1		base/include/StoredPatchNameCapability.h
+23 −0		base/include/Synth.h
+21 −6		base/src/AutoDetection.cpp
+11 −2		base/src/FindSynthOnMidiNetwork.cpp
+3 −2		base/src/MTSFile.cpp
+32 −12		base/src/MidiController.cpp
+2 −2		base/src/MidiRequest.cpp
+7 −0		base/src/Patch.cpp
+2 −2		base/src/ReadonlySoundExpander.cpp
+151 −45		base/src/Synth.cpp
+0 −2		database/JsonSerialization.h
+174 −44		database/PatchDatabase.cpp
+4 −3		database/PatchDatabase.h
+3 −1		database/PatchFilter.h
+3 −3		librarian/AutomaticCategory.cpp
+0 −1		librarian/CMakeLists.txt
+14 −15		librarian/JsonSchema.cpp
+1 −2		librarian/JsonSchema.h
+0 −11		librarian/JsonSerialization.cpp
+0 −2		librarian/JsonSerialization.h
+145 −83		librarian/Librarian.cpp
+5 −2		librarian/Librarian.h
+26 −40		librarian/PatchHolder.cpp
+7 −4		librarian/PatchHolder.h
+35 −5		librarian/PatchInterchangeFormat.cpp
+11 −0		librarian/PatchList.cpp
+1 −0		librarian/PatchList.h
+0 −33		librarian/Session.h
+31 −11		librarian/SynthBank.cpp
+5 −0		librarian/SynthBank.h
+2 −1		librarian/SynthHolder.cpp
+58 −16		librarian/resources/mapping_categories.jsonc
+7 −0		PyTschirpAttribute.h
+7 −0		PyTschirpPatch.h
+7 −0		embedded_module.cpp
+7 −1		pytschirp.cpp