makes most operators hidden friends #471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that they're not placed in their function names' respecitve overload sets, which has a considerable impact on build times and on compiler diagnostics (as they're not listed as failed candidates when overload resolution fails).
Running an include tracer indicated that placing `size_hint_impl.h` in this header should prevent link-time errors when attempting to incidentally format `SizeHint`.
cjdb
force-pushed
the
hidden-friend-operators
branch
from
c8fe86b to
438c023
Compare
danakj
reviewed
May 7, 2025
| @@ -910,6 +910,9 @@ class Choice<__private::TypeList<Ts...>, Tags...> final { | |||
| const Choice<__private::TypeList<RhsTs...>, RhsTag, RhsTags...>& r) = | |||
| delete; | |||
|
|
|||
| // Stream support | |||
There was a problem hiding this comment.
Suggested change
| // Stream support | |
| // Stream support. |
Comment on lines
64
to
+66
| } // namespace __private | ||
|
|
||
| namespace __private { |
There was a problem hiding this comment.
We can avoid closing and opening the namespace here
| /// #[doc.overloads=array.cmp.array] | ||
| template <class U> | ||
| requires(::sus::cmp::ExclusiveStrongOrd<T, U>) | ||
| constexpr friend std::strong_ordering operator<=>( |
There was a problem hiding this comment.
can we write friend constexpr as the order for these keywords consistently (the one above is in that order)?
| std::make_index_sequence<N>()); | ||
| } | ||
|
|
||
| // Stream support |
There was a problem hiding this comment.
Suggested change
| // Stream support | |
| // Stream support. |
| @@ -36,7 +36,8 @@ struct VarError { | |||
| Reason reason; | |||
|
|
|||
| /// Satisfies the [`Eq`]($sus::cmp::Eq) concept. | |||
| constexpr bool operator==(const VarError& rhs) const noexcept = default; | |||
| constexpr friend bool operator==(const VarError& lhs, | |||
There was a problem hiding this comment.
Suggested change
| constexpr friend bool operator==(const VarError& lhs, | |
| friend constexpr bool operator==(const VarError& lhs, |
| } // namespace sus | ||
|
|
||
| // fmt support. | ||
| template <class Char> |
There was a problem hiding this comment.
Same question - can this go to the bottom?
| @@ -748,6 +748,47 @@ _sus_pure constexpr _self _self::from_ne_bytes( | |||
| return _self(val); | |||
| } | |||
|
|
|||
| _sus_pure constexpr u32 _self::count_ones() const& noexcept { | |||
| return __private::count_ones(primitive_value); | |||
There was a problem hiding this comment.
Why did these bodies need to move?
| @@ -0,0 +1,56 @@ | |||
| // Copyright 2023 Google LLC | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2023 Google LLC | |
| // Copyright 2025 Google LLC |
| @@ -60,3 +60,5 @@ | |||
| #define _pointer 1 | |||
| #define _primitive ::sus::num::__private::ptr_type<::sus::mem::size_of<uintptr_t>()>::unsigned_type | |||
| #include "sus/num/__private/unsigned_integer_methods_impl.inc" | |||
| // Comment to prevent clang-format from deleting this line and sorting includes | |||
There was a problem hiding this comment.
Suggested change
| // Comment to prevent clang-format from deleting this line and sorting includes | |
| // This must come last, after the types are fully defined. |
| @@ -775,6 +775,7 @@ class [[nodiscard]] Result final { | |||
| { | |||
| return eq(l, r); | |||
| } | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that they're not placed in their function names' respective overload sets, which has a considerable impact on build times and on compiler diagnostics (as they're not listed as failed candidates when overload resolution fails).