Escapes RegExp chars (mongoose-unique-validator#95)

* Escape RegExp chars * Add tests for regex escaping
chumager · Apr 15, 2019 · c5d1c6e · c5d1c6e
1 parent 08da631
commit c5d1c6e
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -70,6 +70,8 @@ module.exports = function(schema, options) {
 
                                 // Wrap with case-insensitivity
                                 if (get(path, 'options.uniqueCaseInsensitive') || indexOptions.uniqueCaseInsensitive) {
+                                    // Escapse RegExp chars
+                                    pathValue = pathValue.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g, '\\$&');
                                     pathValue = new RegExp('^' + pathValue + '$', 'i');
                                 }
 

diff --git a/test/helpers.js b/test/helpers.js
@@ -232,5 +232,15 @@ module.exports = {
     }, {
         email: '[email protected]',
         username: 'JohnSmith'
+    }],
+
+    USERS_REGEX: [{
+        username: 'JohnSmith0',
+        email: '[email protected]',
+        password: 'j0hnNYb0i0'
+    }, {
+        username: 'JohnSmith',
+        email: '[email protected]',
+        password: 'j0hnNYb0i'
     }]
 };
diff --git a/test/tests/validation.spec.js b/test/tests/validation.spec.js
@@ -22,6 +22,21 @@ module.exports = function(mongoose) {
             promise.catch(done);
         });
 
+        it('allow unique records with regex wildcards', function(done) {
+            var User = mongoose.model('User', helpers.createUserCaseInsensitiveSchema().plugin(uniqueValidator));
+
+            // Save the first user
+            var promise = new User(helpers.USERS_REGEX[0]).save();
+            promise.then(function() {
+                // Try saving a unique user with email that has a regex wildcard
+                new User(helpers.USERS_REGEX[1]).save().catch(done).then(function(res) {
+                    expect(res.email).to.equal(helpers.USERS_REGEX[1].email);
+                    done();
+                });
+            });
+            promise.catch(done);
+        });
+
         it('throws error for single index violation', function(done) {
             var User = mongoose.model('User', helpers.createUserSchema().plugin(uniqueValidator));