tetragon/windows: Compilation only change to build encoder package #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ExceptionalHandler
force-pushed
the
build/windows/encoder
branch
from
22b4759 to
a08e89d
Compare
Added windows specific stub of the function rawSyscallEnter() in encoder/raw_syscall_enter.go listing of encoder package to allow it to compile on Windows Signed-off-by: Anadi Anadi <[email protected]>
ExceptionalHandler
force-pushed
the
build/windows/encoder
branch
from
a08e89d to
841f4e8
Compare
olsajiri
added
the
release-note/minor
olsajiri
approved these changes
Mar 24, 2025
olsajiri
reviewed
Mar 24, 2025
|
|
||
| func rawSyscallEnter(tp *tetragon.ProcessTracepoint) string { | ||
| return "unknown win32" | ||
|
|
There was a problem hiding this comment.
why win32? unknown or 'not supported' would do?
There was a problem hiding this comment.
That is generally what syscalls on Windows are called: win32 APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added windows specific stub of the function
rawSyscallEnter()inencoder/raw_syscall_enter.golisting of encoder package to allow it to compile on WindowsChangelog