-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking and fixing code snippets in documentation #9187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching all these problems! just a couple of little changes
@@ -229,7 +229,8 @@ Using the Android orb gives you two options for deploying to the Google Play Sto | |||
|
|||
[.tab.configAndroidOrb.Use_the_deploy-to-play-store_job] | |||
-- | |||
To deploy using the `deploy_to_play_store` job you just need to add a `android/deploy_to_play_store` job to your list of jobs in your workflow. | |||
To deploy using the `deploy-to-play-store job you just need to add a `android/deploy_to_play_store` job to your list of jobs in your workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To deploy using the `deploy-to-play-store job you just need to add a `android/deploy_to_play_store` job to your list of jobs in your workflow. | |
To deploy using the `deploy-to-play-store job you just need to add an `android/deploy_to_play_store` job to your list of jobs in your workflow. |
@@ -273,18 +273,18 @@ Let's break down the `deploy-model-through-to-prod workflow`. Our first job is ` | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line above I think deploy-model-through-to-prod workflow
should be deploy-model-through-to-prod
workflow
Description
Updating/Fixing code snippets in several documentation pages.
Reasons
Some code snippets are incorrectly formatted or include outdated information.
Content Checklist
Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.
Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 😸: