[ONPREM-1829] [HACKWEEK] Add initial support for Windows containers #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
https://circleci.atlassian.net/browse/ONPREM-1829
⚙️ Change Description
This PR adds support for Windows on container runner. The only updates were made to GOAT and the
runner-init
image. Some changes to the process and signal handling in GOAT needed to be made since it was Linux-centric. In addition, the binary and images needed to be updated in order to target Windows. The base image forrunner-init
needed to also be based on a Windows image, since a container OS is required for Windows, which have been added to the manifest.Example job using a Windows container: https://app.circleci.com/pipelines/github/circleci/runner-dummy/3006/workflows/ccc16261-2422-41a3-8a99-bbd06ad7c6e7/jobs/193687?invite=true#step-102-42_67
The only known limitation of Windows containers is that service containers are currently unsupported. This will be addressed in a followup ticket (ONPREM-1830), which will require targeting Windows for the
logging-collector
binary and image.Acceptance Criteria:
✅ Solution
❓ Testing
📖 Documentation Updates