Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix spelling issues #40

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ For running integration tests in Anvil node, run `make anvil-tests`. This runs t
* Sponsor paymaster `env $(grep -v '^#' .env) npx hardhat verify --network goerli --constructor-args script/sponsor_paymaster_constructor_args.js STABLECOIN_PAYMASTER_ADDRESS`
* Fallback: If the verification commands do not work for contracts deployed through the hardhat deployment scripts, you can still verify manually through etherscan's UI by submitting the standard input json.

You can find this file under `deployments/polygon/solcInputs` (you can try different blockchains but I'm unsure of results). Then submit the file that you think is the one for the contract you're trying to verify. It's a bit of guessing, but you can look at the source code to try and figure it out. You may also need to verify the proxies manually through etherscan after having verified the implementation.
You can find this file under `deployments/polygon/solcInputs` (you can try different blockchains but I'm unsure of the results). Then submit the file that you think is the one for the contract you're trying to verify. It's a bit of guessing, but you can look at the source code to try and figure it out. You may also need to verify the proxies manually through etherscan after having verified the implementation.
#### MSCA
1. Set up `DEPLOYER_PRIVATE_KEY`, `RPC_URL` and `ETHERSCAN_API_KEY` in .env
2. Run `source .env`
Expand Down Expand Up @@ -136,7 +136,7 @@ For running integration tests in Anvil node, run `make anvil-tests`. This runs t

### Deployment Metadata

The below contract deployment are based on abi and bytecode to ensure the same address across all EVM-compatible chains. The abi and bytecode for each of the contracts are available at the locations below. These files were generated from first deployments, will all fields except `abi` and `bytecode` removed.
The below contract deployment is based on abi and bytecode to ensure the same address across all EVM-compatible chains. The abi and bytecode for each of the contracts are available at the locations below. These files were generated from first deployments, will all fields except `abi` and `bytecode` be removed.

| Contract Name | Location |
|:------------------------:|:------------------------:|
Expand Down
2 changes: 1 addition & 1 deletion docs/Smart_Contract_Signatures_Encoding.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ bde0b9f486b1960454e326375d0b1680243e031fd4fb3f070d9a3ef9871ccfd5 (r)
```


Note: signature type += 32 if it's signing over the actual digest in multisig context.
Note: signature type += 32 if it's signing over the actual digest in a multisig context.

The constant parts need to be sorted so that the recovered signers are sorted ascending (natural order) by address (not checksummed).

Expand Down
4 changes: 2 additions & 2 deletions src/paymaster/BasePaymaster.sol
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ import {PausableUpgradeable} from "@openzeppelin/contracts-upgradeable/utils/Pau
* The deposit (for paying gas fees) is separate from the stake (which is locked).
* Note that this signature is NOT a replacement for the account-specific signature:
* - the paymaster checks a signature to agree to pay for gas.
* - the account checks a signature prove identity and account ownership.
* Since this contract is upgradable, we do not allow use either selfdestruct or delegatecall to prevent a malicious
* - the account checks a signature to prove identity and account ownership.
* Since this contract is upgradable, we do not allow the use of either selfdestruct or delegatecall to prevent a malicious
* actor from
* destroying the logic contract.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/utils/ExecutionUtils.sol
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ pragma solidity 0.8.24;
// solhint-disable no-inline-assembly

/**
* Utility functions helpful when making different kinds of contract calls in Solidity.
* Utility functions are helpful when making different kinds of contract calls in Solidity.
* For inline assembly, please refer to https://docs.soliditylang.org/en/latest/assembly.html
* For opcodes, please refer to https://ethereum.org/en/developers/docs/evm/opcodes/ and https://www.evm.codes/
*/
Expand Down