feat: Add EP0.7 audited MSCA contracts testnet deployment logs and update scripts #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutosh-ukey
requested review from
huaweigu,
dlim-circle and
stigter-circle
ashutosh-ukey
changed the title
huaweigu
reviewed
Sep 26, 2024
huaweigu
reviewed
Sep 26, 2024
ashutosh-ukey
force-pushed
the
deploy-ep0.7-audited-MSCA-contracts
branch
from
cb52582 to
7d1e1ea
Compare
huaweigu
reviewed
Sep 26, 2024
dlim-circle
reviewed
Sep 26, 2024
dlim-circle
reviewed
Sep 26, 2024
ashutosh-ukey
force-pushed
the
deploy-ep0.7-audited-MSCA-contracts
branch
from
383e633 to
8d75ec8
Compare
huaweigu
reviewed
Sep 27, 2024
ashutosh-ukey
changed the title
huaweigu
approved these changes
Sep 27, 2024
|
LGTM. @dlim-circle could you please take another look at your convenience? |
dlim-circle
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
@ashutosh-ukey Think you asked previously, did you also wanted to deploy the mainnet contracts for plugins that doesn't need owners?
huaweigu
pushed a commit
that referenced
this pull request
Sep 27, 2024
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2024-09-27) ### Features * Add EP0.7 audited MSCA contracts testnet deployment logs and update scripts ([#6](#6)) ([4294cc2](4294cc2)) * Deployed and Verified SponsorPaymaster on Testnet ([#2](#2)) ([9cdf6dc](9cdf6dc)) ### Miscellaneous Chores * **ci:** Minor refactor to release workflow ([#4](#4)) ([01ece52](01ece52)) * **style**: organize imports ([#1](#1)) ([1d2d26c](1d2d26c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
@dlim-circle I will deploy those ones locally and update our internal docs, but I was planning on bunching together all of the mainnet MSCA audited contract deployment logs into one big PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update deployment scripts and add deployment logs for audited MSCA EP0.7 contracts.
Checklist
yarn test)docsfolder)feat!: breaking change)yarn lint) and fix any issues?yarn format:check) and fix any issues (yarn format:write)?Testing
All the script changes were tested locally in the process of deploying the new contracts. Any edits made during the PR review process were tested by simulating the script and verifying that there were no errors. I tested the
cast sendcommands on a local networks and verified that contracts were deployed at the same addresses as those deployed using theforge scriptcommand.