Feature/edit circle #14
Merged
+2,831
−1,154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
동아리 정보 수정 상황인 경우, setOrigin 함수를 통해 별도로 원본 데이터를 뷰모델 내에 저장하였으나, 이는 의존성 주입과 일맥상통하기 때문에 획일화를 위해 뷰모델에 별도로 동아리 원본 데이터에 대한 의존성을 주입함 최초 동아리 생성인 경우, 동아리 원본 데이터를 null 로 설정하면, 뷰모델 내 동아리 데이터는 CircleDetailEmptyModel 로 초기화
기존 작업별 UiState 를 즉시 반영하지 않고, invokeOnCompletion, async(Deffered) 를 이용해 ErrorState 가 발생하는 즉시 부모 코루틴을 캔슬하고, 그렇지 않은 경우 일괄적적으로 Success State 반영
CategoryAdapter 재사용을 위해 ViewModel 의존성을 제거하고, 새로운 CategoryModel, CategoryModels 와 DiffUtil 을 활용하여 Adapter 재작성
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.