Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Commit

Permalink
Update to node 18, edit cypress workflow (#136)
Browse files Browse the repository at this point in the history
* update to node 18, edit cypress workflow
* upgrade cypress
* change baseurl format
* host true on vite server host
  • Loading branch information
sang2925 authored May 24, 2023
1 parent 36fb35b commit 6d77c83
Show file tree
Hide file tree
Showing 8 changed files with 32 additions and 32 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.19.0]
node-version: [18.16.0]

steps:
- uses: actions/checkout@v3
Expand All @@ -27,7 +27,7 @@ jobs:
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: 16.19.0
node-version: 18.16.0
cache: 'yarn'
- run: CYPRESS_INSTALL_BINARY=0 yarn install --immutable --inline-builds
- run: CYPRESS_INSTALL_BINARY=0 yarn moon ci
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
CYPRESS_INSTALL_BINARY: 0
strategy:
matrix:
node-version: [16.19.0]
node-version: [18.16.0]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand All @@ -31,4 +31,3 @@ jobs:
with:
name: RedEye
path: artifacts

38 changes: 19 additions & 19 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ jobs:

install:
needs: ['prepare']
container:
image: cypress/browsers:node16.16.0-chrome105-ff104-edge
options: --user 1001
# container:
# image: cypress/browsers:node16.16.0-chrome105-ff104-edge
# options: --user 1001
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version: [16.20.0]
# matrix:
# node-version: [16.20.0]
steps:
- name: Checkout
uses: actions/checkout@v3
Expand All @@ -43,7 +43,7 @@ jobs:
- name: Cache
uses: actions/setup-node@v3
with:
node-version: 16.20.0
node-version: 18.16.0
cache: 'yarn'

- run: yarn install --immutable --inline-builds
Expand All @@ -58,15 +58,15 @@ jobs:

RedTeamChrome:
runs-on: ubuntu-latest
container:
image: cypress/browsers:node16.16.0-chrome105-ff104-edge
options: --user 1001
# container:
# image: cypress/browsers:node16.16.0-chrome105-ff104-edge
# options: --user 1001
needs: [prepare, install]
strategy:
fail-fast: false
matrix:
containers: [1, 2]
node-version: [16.20.0]
# node-version: [16.20.0]

steps:
- name: Checkout
Expand All @@ -77,7 +77,7 @@ jobs:
- name: Cache
uses: actions/setup-node@v3
with:
node-version: 16.20.0
node-version: 18.16.0
cache: 'yarn'

- name: Download the build folders
Expand All @@ -87,10 +87,10 @@ jobs:
path: .moon/cache

- run: yarn install --immutable --inline-builds
- name: Red Team Tests - Chrome v${{ matrix.node }}
- name: Red Team Tests - Chrome
uses: cypress-io/github-action@v5
with:
tag: node-${{ matrix.node }}
# tag: node-${{ matrix.node }}
start: yarn start:dev
wait-on: 'http://localhost:4000/api/graphql, http://localhost:3500'
browser: chrome
Expand All @@ -107,15 +107,15 @@ jobs:

BlueTeamChrome:
runs-on: ubuntu-latest
container:
image: cypress/browsers:node16.16.0-chrome105-ff104-edge
options: --user 1001
# container:
# image: cypress/browsers:node16.16.0-chrome105-ff104-edge
# options: --user 1001
needs: [prepare, install]
strategy:
fail-fast: false
matrix:
containers: [1, 2]
node-version: [16.20.0]
# node-version: [16.20.0]

steps:
- name: Checkout
Expand All @@ -126,7 +126,7 @@ jobs:
- name: Cache
uses: actions/setup-node@v3
with:
node-version: 16.20.0
node-version: 18.16.0
cache: 'yarn'

- name: Download the build folders
Expand All @@ -139,7 +139,7 @@ jobs:
- name: 'Blue Team Tests - Chrome'
uses: cypress-io/github-action@v5
with:
tag: node-${{ matrix.node }}
# tag: node-${{ matrix.node }}
start: yarn start:blue
wait-on: 'http://localhost:4000/api/graphql, http://localhost:3500'
browser: chrome
Expand Down
2 changes: 1 addition & 1 deletion .moon/toolchain.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ $schema: 'https://moonrepo.dev/schemas/toolchain.json'
node:
# The version to use. Must be a semantic version that includes major, minor, and patch.
# We suggest using the latest active LTS version: https://nodejs.org/en/about/releases
version: '16.20.0'
version: '18.16.0'

# The package manager to use when managing dependencies.
# Accepts "npm" (default), "pnpm", or "yarn".
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.20.0
18.16.0
1 change: 1 addition & 0 deletions applications/client/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export default defineConfig(() => ({
},
server: {
port: 3500,
host: true,
hmr: {
overlay: false,
},
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
"builder-util": "^23.0.2",
"concurrently": "^7.6.0",
"cross-env": "^7.0.3",
"cypress": "^12.11.0",
"cypress": "^12.13.0",
"cypress-map": "^1.19.1",
"cypress-multi-reporters": "^1.6.1",
"cypress-real-events": "^1.7.6",
Expand Down Expand Up @@ -208,7 +208,7 @@
]
},
"engines": {
"node": "16.20.0"
"node": "18.16.0"
},
"packageManager": "[email protected]"
}
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6150,9 +6150,9 @@ __metadata:
languageName: node
linkType: hard

"cypress@npm:^12.11.0":
version: 12.11.0
resolution: "cypress@npm:12.11.0"
"cypress@npm:^12.13.0":
version: 12.13.0
resolution: "cypress@npm:12.13.0"
dependencies:
"@cypress/request": ^2.88.10
"@cypress/xvfb": ^1.2.4
Expand Down Expand Up @@ -6198,7 +6198,7 @@ __metadata:
yauzl: ^2.10.0
bin:
cypress: bin/cypress
checksum: 56e5ebaec59dffca5d19704f2b2674cbb0002f20050c1d624217ede157c528757f58ad42f0899fc67c32c61d5461eef5e2a3a99a6a52b77b152362a025a22599
checksum: 8e73c7033dadc15caf17b106cd88665107c8bbf3ba66fc266de1f14a2c1401edfa99c222f2ae6070e1ffb8123eb255fb559dc3e5e24460fadf8e05ce74afa41b
languageName: node
linkType: hard

Expand Down Expand Up @@ -13197,7 +13197,7 @@ __metadata:
cors: ^2.8.5
cross-env: ^7.0.3
crypto-js: ^4.0.0
cypress: ^12.11.0
cypress: ^12.13.0
cypress-map: ^1.19.1
cypress-multi-reporters: ^1.6.1
cypress-real-events: ^1.7.6
Expand Down

0 comments on commit 6d77c83

Please sign in to comment.