Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDA host port onboarding module - 1 Enhancement & 4 Bug fixes #106

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rukapse
Copy link
Collaborator

@rukapse rukapse commented Jan 31, 2025

Description

PR Includes the fixes for the SDA Host Port Onboarding Module issues listed below:

1. Delete port-channel: "port_channel_name" needs indentifying
2. iac2.0: sda-host-port: Failed with params which are part of the module spec.
3. iac2.0: sda-host-port: Port channel shold allow to add/Remove interfaces to port channel
4. iac2.0: sda-host-port: create port channels gets into error
5. Enhancement - Wireless SSIDs remove all feature 

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

@rukapse rukapse requested a review from madhansansel as a code owner January 31, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant