Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add superlinter #18

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Add superlinter #18

merged 5 commits into from
Dec 11, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 10, 2024 •
edited
Loading

This adds superlinter as a workflow and also applies (most) fixes required to make it pass properly.

Changes applied:

  • Formatting
  • Rename entrypointk8s.sh to entrypoint.sh for java
  • Move examples out of src/services to top level
  • Bash escaping and quoting where necessary
  • Add the superlint workflow

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@svrnm svrnm requested a review from a team as a code owner December 10, 2024 16:25
noMoreCLI
noMoreCLI approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@noMoreCLI noMoreCLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@noMoreCLI noMoreCLI merged commit d382825 into main Dec 11, 2024
2 of 3 checks passed
@svrnm svrnm deleted the add-superlinter branch December 18, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noMoreCLI noMoreCLI noMoreCLI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svrnm @noMoreCLI