Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove openssl version check #750

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

pabuhler
Copy link
Member

This is a follow on from #744 / #745 but for other build systems.

Now that OpenSSL 1.1 is EOL there is no need to
enforce version checks.

This does not remove support for building against
OpenSSL 1.1 .

This is a follow on from cisco#744 / cisco#745 but for other
build systems.

Now that OpenSSL 1.1 is EOL there is no need to
enforce version checks.

This does not remove support for building against
OpenSSL 1.1 .
Copy link
Contributor

@paulej paulej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds fine, but I noted that the zlib development libraries must be installed for the configure script to work, though it doesn't appear to really be necessary. It's unclear why this requirement exists. CMake does not impose the same requirement. Perhaps it's something intrinsic to autotools? Not sure.

@pabuhler
Copy link
Member Author

Thanks @paulej, I guess you comments are related to #631 , will try to resolve before v3.0 is released.

@pabuhler pabuhler merged commit def2d64 into cisco:main Feb 17, 2025
39 checks passed
@pabuhler pabuhler deleted the remove-openssl-version-check branch February 17, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants