feat: molecule codec #88
Conversation
|
| return result; | ||
| }, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
These can be replaced by
https://docs.ckbccc.com/functions/_ckb_ccc_core.index.ccc.numToBytes.html
packages/core/src/codec/number.ts
Outdated
| import { CodecBaseParseError } from "./error.js"; | ||
|
|
||
| type BI = Num; | ||
| type BIish = NumLike; |
There was a problem hiding this comment.
BI is different with Num, we should replace these type names.
| @@ -0,0 +1,127 @@ | |||
| import { | |||
There was a problem hiding this comment.
Some code in this file is not needed anymore, please remove them.
packages/core/src/codec/base.ts
Outdated
| >; | ||
|
|
||
| export type BytesCodec<Unpacked = any, Packable = Unpacked> = Codec< | ||
| Uint8Array, |
There was a problem hiding this comment.
| Packable | ||
| >; | ||
|
|
||
| export type BytesCodec<Unpacked = any, Packable = Unpacked> = Codec< |
There was a problem hiding this comment.
It seems that the Uint8ArrayCodec should be replaced by BytesCodec.
There was a problem hiding this comment.
there's a little different, BytesCodec accepts BytesLike as parameter for unpack method, in contrast, Uint8ArrayCodec only accepts Uint8Array
There was a problem hiding this comment.
I can only preserve BytesCodec as the concrete bytes encode/decode, and have every external callers to transfer its BytesLike parameter using ccc.bytesFrom before pack/unpack
| const HexUint8 = asHexadecimal(Uint8); | ||
| const HexUint32LE = asHexadecimal(Uint32LE); | ||
| const HexUint64LE = asHexadecimal(Uint64LE); | ||
| const HexUint128LE = asHexadecimal(Uint128LE); |
There was a problem hiding this comment.
Maybe we don't need these, just Uint8 should be enough. We used Uint8 for HashType but HexUint8 for DepType, this doesn't make sense.
There was a problem hiding this comment.
Hex prefixed types are unpacking to output string, all of these are used in below codes, I'm not sure to delete them.
| if (type === "data2") return Uint8.pack(0b0000010_0); | ||
| throw new Error(`Invalid hash type: ${type}`); | ||
| }, | ||
| unpack: (buf) => { |
There was a problem hiding this comment.
| if (type === "code") return HexUint8.pack(0); | ||
| if (type === "depGroup") return HexUint8.pack(1); | ||
| throw new Error(`Invalid dep type: ${type}`); | ||
| }, |
There was a problem hiding this comment.
| @@ -0,0 +1,8 @@ | |||
| export { byteArrayOf, byteOf, byteVecOf } from "./helper.js"; | |||
There was a problem hiding this comment.
Maybe we can export everything here?
| @@ -9,3 +9,4 @@ export * from "./keystore/index.js"; | |||
| export * from "./num/index.js"; | |||
| export * from "./signer/index.js"; | |||
| export * from "./utils/index.js"; | |||
| export * as codec from "./codec/index.js"; | |||
There was a problem hiding this comment.
Personally I think pack unpack Packed Unpacked Packable Unpackable are confusing. It looks like Packed is always Bytes here. Maybe we don't need this much flexibility.
I suggest to use
encode decode DataType instead, and encoder result should always be Bytes.
See https://en.wikipedia.org/wiki/Codec#:~:text=A%20codec%20is%20a%20device,a%20portmanteau%20of%20coder%2Fdecoder.
There was a problem hiding this comment.
confusing indeed there, because of it, I'm concerned to alter it, afraid of causing unexpected problems, however, speaking of which, I'd like to have a try fixing it.
There was a problem hiding this comment.
How about just changing them to:
Packed => Encoded
Packable => Encodable
Unpacked => Decoded
Unpackable => Decodable
#Description
migrate whole @ckb-lumos/codec package into ccc and replace with this new codec of ccc for native Spore package, which test cases have passed