-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the plugin size #202
Comments
Yea, I can see Quail is inlined. Without Quail built plugin.js is 43KB compared to 175KB when Quail is added. |
As https://www.drupal.org/node/2731373#comment-11243745 explains, we'd love to include the So, when you implement this on-demand loading, can you please also make it possible to let the site specify the location of the |
Yes, it makes a perfect sense. We were thinking about this at the beginning, but for some reason this has slipped out. I've extracted this request to #204. |
Looking forward to this! So good to be able to bring accessibility right to the content editors. Big step towards ATAG 2.0 compliance too. |
I've just made two builds in the online builder, one with A11y Checker and another without it. The following is the size of
ckeditor.js
in both cases:In theory, QUAIL and tests should be loaded on demand when clicking on the A11y Checker button. Therefore, almost 200 KB on the plugin size seems to be a bit too excessive. It should be checked what is ending up in the plugin file and if the loading on demand mechanism is working properly.
The text was updated successfully, but these errors were encountered: