-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to provide a custom Quail path #204
Comments
Hi everyone - thanks so much for your work on this great piece of open source software. A11y is so important, and I'm really pleased this plugin exists. I'm excited that we might be able to include a11ychecker in Drupal core - and resolving this issue will help make that happen! Thanks again. |
I've implemented a proposed solution: 3dbdef0. Tests are green, manual passes, also the built version works(the Is a manual test in order here? |
Definitely yes, remember to include ticket number and target version as a tag. |
@Tade0 see my comment in the PR #218 (comment). |
Turns out this solution didn't work for the start. Fixed it and re-written the tests. |
Just wondering, what are we waiting for now? Anything that we (the Drupal community) can do to move this forward? Thanks! |
Hi @BarisW we're currently consumed with tasks around CKEditor 4 and CKEditor 5, and having hard time reviewing this issue. Here we need to review the issue so it's more of a CKSource task. However you might help just checking out the solution from #218 and seeing if it works well for you, dropping comments which will be also a nice feedback for the reviewer. |
Quail is officially depreciated - https://github.com/quailjs/quail-core They recommend moving to https://github.com/dequelabs/axe-core |
There has been some movement on this from within the Drupal community https://www.drupal.org/project/drupal/issues/2731373#comment-13264600 |
We need to modify Quail engine adapter in a way that it allows to provide a custom path to the Quail's main
.js
file.One thing to keep in mind is that also all the
.json
files should be fetched from a given location.This issue originated from #202.
The text was updated successfully, but these errors were encountered: