This repository was archived by the owner on Sep 4, 2021. It is now read-only.
Tuyadevice #69
Open
Tuyadevice #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values - changed typing of set_value as the value can be other types too
|
@edenhaus This new device class looks handy! It would be super useful if you could set multiple statuses at once too. |
|
pytuya is dead.... unfortunately |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @clach04,
I create a new class TuyaDevice, which allow to get the status and set values. As example prosenic vacuum cleaner is using tuya. As the dps are different to the Device class, I introduce the new class for only getting the status and setting values.
I also cleaned the code a little bit and removed all print statements and comment out code. In my opinion this helps to increase the code quality. Instead of print statement, we should use the logger.
I fixed also the tests. The was failing, because the didn't expect a crc in the message.
Cheers,
Robert