Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Make userId nullable for Identify on Android #59

Merged

Conversation

danielgomezrico
Copy link
Contributor

@danielgomezrico danielgomezrico commented Jun 2, 2021

This PR will allow the userId to be null on identify, the segment library for each platform allows it.

I added another branch before the Null Safety was merged to be able to use this if you have not migrated your app here: la-haus#1.

@danielgomezrico danielgomezrico changed the title Make userId nullable for Identify Make userId nullable for Identify (with Null Safety) Jun 2, 2021
@danielgomezrico danielgomezrico marked this pull request as ready for review June 2, 2021 23:21
@danielgomezrico
Copy link
Contributor Author

@MaiKaY @vinicius-animo @kev52 ping :)

@danielgomezrico
Copy link
Contributor Author

@MaiKaY @vinicius-animo @kev52 ping 2 :)

@MaiKaY MaiKaY merged commit 7019826 into claimsforce-gmbh:master Jun 30, 2021
@MaiKaY
Copy link
Contributor

MaiKaY commented Jun 30, 2021

Thanks @danielgomezrico, it's available in 3.1.1

I would like to ask you to check #57

@MaiKaY MaiKaY mentioned this pull request Jun 30, 2021
@danielgomezrico danielgomezrico changed the title Make userId nullable for Identify (with Null Safety) Make userId nullable for Identify on Android Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userId for Identify should be optional
2 participants