Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @clarkbw,
A few peers of mine recently ran into some issues with understanding how to properly override the storage mocks within this library.
mockImplementation
leads to the mock being completely overwritten and persisting throughmockClear
calls. Though this might be clear to a lot of developers familiar withJest
, the behavior under the hood might not be as clear to those less familiar. We can leverage edge case mock overrides withmockImplementationOnce
in our case due to how jest handlesspecificMockImpls
under the hood here.I have added some documentation to the README in 477a7e8 to help guide users in the right direction so the options to override the mock in edge cases are clearly understood.
While I was in there, I fixed a few small spelling errors and ran the linter. I hope that is OK! 😄
Let me know what you think when you can and thanks in advance for taking a look at this.