Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rename regression_test.py to use pytest #562

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rjleveque
Copy link
Member

See also clawpack/classic#90

Gives 4 errors currently, 3 of which are related to precision of results.

=========================== short test summary info ============================
FAILED test_storm.py::test_storm_IO - TypeError: 'DataArray' object cannot be interpreted as an integer
FAILED bowl_slosh/regression_test.py::BowlSloshTest::runTest - AssertionError: 
FAILED dtopo1/regression_test.py::DTopoTests::runTest - AssertionError: 
FAILED particles/regression_test.py::ParticlesTest::runTest - AssertionError: 
============ 4 failed, 26 passed, 2 skipped, 16 warnings in 41.24s =============

@mandli: maybe you can figure out what's wrong with test_storm.py and I'll look into the other failures. It seems like the results agree to about single precision but not to the specified tolerances.

Gives 4 errors currently, 3 of which are related to precision of results.
regression_data/gauge00001.txt also updated, very minor changes from previous
@rjleveque
Copy link
Member Author

The disagreement with regression data is probably due to some changes in how regions are applied and hence what AMR grid patches are used. There are similarly small changes for a couple of amrclaw tests.

I updated the regression_data directories so that tests should all pass, except for test_storm.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant