-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Compile and install 3D Euler with gravity example #723
[WIP] Compile and install 3D Euler with gravity example #723
Conversation
Is there a reason for moving the Riemann solver out of the Riemann repository and into PyClaw? That's generally the opposite of what we want to do. |
@ketch I tried to do something similar to Then, I will leave the Riemann solver in the Should the mapGrid module |
I should have been more clear before. I think that all we want to do is add the code required for meson to compile what is already in this example directory. |
That specific example is provided to show users how to incorporate their own Riemann solver. For all other examples, we keep the Riemann solver in
That's correct.
That's a good question; technically that code is not "Riemann solver" code, but it's basically required whenever one uses the 3D Euler mapped grid Riemann solver, so I think it makes sense to leave it in Riemann. |
Ok, I'll add just the necessary changes for that in this PR and create another one for the compilation in the Riemann repository. |
@@ -340,7 +340,7 @@ def euler3d(kernel_language='Fortran',solver_type='classic',\ | |||
claw.solver = solver | |||
claw.output_format = output_format | |||
claw.output_file_prefix = file_prefix | |||
claw.keep_copy = False | |||
claw.keep_copy = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's best to leave this set to False
by default. If someone tries running this with a larger grid, they could easily run out of memory.
I made the changes. The imports in |
The
pyclaw/examples/euler_gravity_3d
example is compiled and installed at run-time.The Fortran source is now located in this directory.The changes in this PR are tested here, along with #721 (although this PR does not depend on #721).
If this PR is merged, the fileseuler3d_mappedGrid.f90
,rpn3_euler_mapgrid.f90
,rpt3_euler_mapgrid.f90
, andrptt3_euler_mapgrid.f90
could be removed fromsrc
directory in theriemann
repository.