Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User's data normalization #671

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

User's data normalization #671

wants to merge 5 commits into from

Conversation

jjpaulino
Copy link
Member

@jjpaulino jjpaulino commented Jul 11, 2019 •
edited
Loading

Solving an issue where the users data in the meta of the page and the _users endpoint wasn't synced.

We'll only handle the properties that shouldn't change and request for the changeable information (like the name or picture) everytime we need.

This is going to work in conjunction with a clay-kiln, amphora-auth and amphora-search change

Issue

@coveralls
Copy link

coveralls commented Jul 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2376

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2374: 0.0%
Covered Lines: 4043
Relevant Lines: 4043
💛 - Coveralls

@jjpaulino
Copy link
Member Author

Denormalize page-list users

manuelurenah
manuelurenah approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@manuelurenah manuelurenah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

pedro-rosario
pedro-rosario approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@pedro-rosario pedro-rosario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Do you think we should add the boostrap data of the robot user somewhere?

@manuelurenah manuelurenah mentioned this pull request Sep 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-owen james-owen james-owen approved these changes

@manuelurenah manuelurenah manuelurenah approved these changes

@pedro-rosario pedro-rosario pedro-rosario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjpaulino @coveralls @pedro-rosario @manuelurenah @james-owen