Remove slugToSiteName helper #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjpaulino
force-pushed
the
remove-helper
branch
7 times, most recently
from
8e178cc to
475ffdb
Compare
jjpaulino
force-pushed
the
remove-helper
branch
from
475ffdb to
28b4c30
Compare
jjpaulino
commented
Nov 6, 2018
| // add the current component before any ads | ||
| newContent.push(component); | ||
| if (componentType === afterComponent) { | ||
| if (componentType === afterCmp) { | ||
| /* istanbul ignore else */ |
jjpaulino
commented
Nov 6, 2018
| if (articleData.inSplashMobileAd) { | ||
| newContent.push(articleData.inSplashMobileAd); | ||
| } | ||
| /* istanbul ignore else */ |
jjpaulino
commented
Nov 6, 2018
| if (articleData.inSplashTabletAd) { | ||
| newContent.push(articleData.inSplashTabletAd); | ||
| } | ||
| /* istanbul ignore else */ |
rmfarrell
approved these changes
Nov 6, 2018
manuelurenah
approved these changes
Nov 7, 2018
labreu05
approved these changes
Nov 9, 2018
nelsonpecora
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper was causing a frontend bug in articles because the sites were outdated and, since it is pretty much
sitesspecific, we decided to move it from here to here.