fixed #256. added runtimeClassName and fixed incorrect placement of nodeSelector #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodeSelector was incorrectly placed under the container. moved it to pod spec added runtimeClassName to the pod spec to select specific GPU nodes.
|
Can you pls re-run |
|
CI still failing on helm-docs, this is really weird but it looks, there are some space/newline differences from helm-docs autogeneration script. What version of helm-docs are you using to generate readme? |
|
First tried helm-docs version 1.11.3 on windows |
|
Hang on, you are including in PR files from helm-docs also for other charts than just clearml-serving. I didn't noticed it immediately, pls remove these ones from PR and it should be good |
…ithub.com/stephanbertl/clearml-helm-charts into fix-serving-nodeselector-runtimeclassname
…ithub.com/stephanbertl/clearml-helm-charts into fix-serving-nodeselector-runtimeclassname
|
Ok, I fixed them for you, let's see if CI si good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
nodeSelector was incorrectly placed under the container. moved it to pod spec
added runtimeClassName to the pod spec to select specific GPU nodes.
Checklist
CONTRIBUTING.mdguide (required)helm lint(required)versioninChart.yamlaccording semver rules (required)annotationssection inChart.yamlannotating implementations (useful for Artifecthub changelog) (required)Which issue(s) this PR fixes:
Fixes #256
Special notes for your reviewer: