-
Notifications
You must be signed in to change notification settings - Fork 114
feat: upgrade React Table v7 to TanStack Table v8 #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Replace react-table with @tanstack/react-table dependency - Update all imports and type definitions - Migrate column definitions to new ColumnDef format - Replace useTable hook with useReactTable - Update sorting to use SortingState - Preserve all existing functionality including virtual scrolling, sorting, search, row selection, inline editing, CSV export, pagination, and cell preview Co-authored-by: Anguel <[email protected]>
Bug Report
Comments? Email us. |
@claude can you fix the 3 issues in the Jazzberry comment? |
Claude finished @modelorona's task —— View job Todo List:
SummaryI've successfully fixed all 3 issues identified by Jazzberry: 1. Incorrect Cell Value Update (High)
2. Single-Column Sorting (Medium)
3. Incorrect Data Export (Medium)
The fixes preserve all existing TanStack Table v8 functionality while addressing the reported bugs. |
- Fix cell value reverting on API error by updating data only after successful response - Enable multi-column sorting by maintaining sort state array - Fix export to use original data order instead of sorted/filtered view - Add error notification when cell updates fail Co-authored-by: Anguel <[email protected]>
Bug Report
Comments? Email us. |
@claude can you fix the latest jazzbery issue if it is actually occurring? |
Claude finished @modelorona's task —— View job Todo List:
SummaryAfter thoroughly analyzing the code, I've determined that the reported issue does not exist. The table component already correctly handles row updates when sorted. How it works:
Key implementation (lines 588-611): // Get the original row index from the sorted row
const sortedRow = rows[index];
const originalIndex = sortedRow.original.originalIndex as number;
// Update using the original index, not the sorted index
const dataIndex = newValue.findIndex(item => item.originalIndex === originalIndex); No changes were needed as the implementation already handles sorted tables correctly. |
@claude the spacing in the table is messed up: this is what it should look like: please fix it |
Claude finished @modelorona's task —— View job Todo List:
SummaryI've fixed the table spacing issue by increasing the row height from 31px to 48px in the |
Co-authored-by: Anguel <[email protected]>
Bug Report
Comments? Email us. |
…hodb into claude/issue-74-20250618_195901
Summary
Upgrades the table component from React Table v7 to TanStack Table v8 while preserving all existing functionality.
Closes #74
Changes
Generated with Claude Code