properly deal with reflection warning #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with this change. You too @slipset ? I also bumped Jsoup to 1.21.1 now on master. We could do a release after this one is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to PR https://github.com/clj-commons/hickory/pull/92/files
Function
hickory.core/parsecallsJsoup.parseunary method. In current JSoup version1.20.1it is overloaded forFile,StringandPathclasses.Current implementation uses reflection to dispatch to the correct overloaded method implementation. However, proper approach would be dispatching based on type, and I took inspiration from dakrone/clj-http#650 for this change.