Refactor has-extern? / js-tag #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… js-tag * test are failing because - we have a bad hack that assumes we have an instance - extern-var-info doesn't tell us what the *resolved* prefix is
… to continue resolving * can infer console.log again
- we only care about var info for the last property - we don't what prefix resolution to clobber the actual instance var info * remove js-tag, incomplete, instead use resolve-extern
* add normalize-unresolved-prefix to fix up the cases we can't find * add impl unit tests * all externs infer tests passing again
- CLJS uses boolean - but externs inference returns js/Boolean * in resolve-var add the ctor to the tag to track later, this also lets the extra information flow * in analyze-dot check to see if the target is a constructor - if it is use that tag instead, Function is not desirable * safe-test? needs to check js/Boolean now * unit tests
…s bound to a local
* show that type inference for a crypto.subtle call works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.