Error writing to upstream #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in loops to make sure we both publish and consume
Is even more fair when there are many connections
For instance, when a client A sends Pub/Headers frames but not the Body frame and then exits, then when the next client tries to publish the upstream servers is not expected a Publish frame but is waiting for that Body frame that will never come.
|
No channels are safe for reuse, even publish only channels might be in a bad state if not all Pub/Header/Body frames has been sent by the client before disconnect. |
|
Fiber yield every 4096 frame to balance full throttle connections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP:
This suppress some errors that shouldnt be logged when a channel is already closed.
Yields fiber read/write loops to make sure we can both publish and consume without locking.
Adresses some parts of #157