Set upstream connection_name to hostname #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes exposes the podname via the `gethostname` glibc call. This will show the podname as the easy to read identifier for the connection. Fixes #187 Could expose it as a config variable too, but I think this addresses the need and is much simplier, both as a patch and for the user to use.
snichme
reviewed
Nov 12, 2024
|
The original issue requested to able to see which pod the connection came from, which this addresses. A custom config per pod seems more of a hassle? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes exposes the podname via the
gethostnameglibc call. This will show the podname as the easy to read identifier for the connection.Fixes #187
Could expose it as a config variable too, but I think this addresses the need and is much simplier, both as a patch and for the user to use.