Skip to content

Commit

Permalink
Ensure action fails if bin/missing-versions fail
Browse files Browse the repository at this point in the history
Previously we'd "shadow" the bin/missing-version exit code with the one from `echo`, split into two discrete steps to catch that.
  • Loading branch information
walro committed Sep 16, 2024
1 parent d2b9939 commit 40eaa0a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/build-all-and-upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ jobs:
ruby-version: ruby
- name: Check missing versions
id: missing-versions
run: echo "matrix=$(bin/missing-versions)" >> "$GITHUB_OUTPUT"
run: |
missing_versions=$(bin/missing-versions)
echo "matrix=$missing_versions" >> "$GITHUB_OUTPUT"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PACKAGECLOUD_TOKEN: ${{ secrets.PACKAGECLOUD_TOKEN }}
Expand Down

0 comments on commit 40eaa0a

Please sign in to comment.