Ensure action fails if bin/missing-versions fail
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we'd "shadow" the bin/missing-version exit code with the one from `echo`, split into two discrete steps to catch that.
walro
requested review from
oskgu360,
gomoripeti,
LoisSotoLopez and
nordlundj
as code owners
|
Great success! (the ❌) |
I have a fix for the ❌ too, but didn't want to mix that in same PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd "shadow" the
bin/missing-versionsexit code with the one fromecho, split into two discrete steps to catch that.See example at https://github.com/cloudamqp/erlang-packages/actions/runs/10880399934 where it's hard to understand what went wrong without looking closer.