Build packages for Ubuntu 24.04 (Noble Numbat) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed while building: > - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 99)
They link to GitHub these days (https://openssl-library.org/source/old/1.1.1/index.html). However, we need `-L` (follow redirects) as GitHub redirects to S3. Also use latest 1.1.1 for good measure.
Utilize `dpkg-shlibdeps(1)` to build the list of dependencies, this was needed as the old approach was not compatible with Noble. Under Noble, we have "diversions" to handle: ``` $ dpkg -S ld-linux-aarch64.so.1 libc6:arm64: /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 libc6:arm64: /usr/lib/ld-linux-aarch64.so.1 diversion by libc6 from: /lib/ld-linux-aarch64.so.1 diversion by libc6 to: /lib/ld-linux-aarch64.so.1.usr-is-merged diversion by libc6 from: /lib/ld-linux-aarch64.so.1 diversion by libc6 to: /lib/ld-linux-aarch64.so.1.usr-is-merged ``` Using `dpkg-shlibdeps` will also make a difference in that it will add version constraints while our older approach would not. I believe it is an improvement though. Example: ``` $ docker build --progress=plain --target tester --build-arg image=ubuntu:jammy --build-arg erlang_version=26.0 --build-arg rabbitmq_version=3.13.0 . # now => Depends: procps, libc6 (>= 2.34), libgcc-s1 (>= 3.0), libstdc++6 (>= 11), libtinfo6 (>= 6), zlib1g (>= 1:1.2.8) # before => Depends: procps, libc6,libgcc-s1,libstdc++6,libtinfo6,zlib1g ```
walro
requested review from
oskgu360,
gomoripeti,
LoisSotoLopez and
nordlundj
as code owners
walro
commented
Aug 26, 2024
oskgu360
approved these changes
Aug 26, 2024
|
Bootstrapped with the 21.3.8.24 package built from this repo, worked. So I think rest is likely fine too. |
carlhoerberg
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits, biggest change is that we will use
dpkg-shlibdeps(1)to get the list of dependencies. It will change the behavior slightly, as we will now have versions constraints which I would argue is a slight improvement.Example: