Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lavinmq service #13

Merged
merged 3 commits into from
May 6, 2024
Merged

Lavinmq service #13

merged 3 commits into from
May 6, 2024

Conversation

kickster97
Copy link
Member

Let LavinMQ be run with brew services, by adding a service block according to Homebrew docs

Also updates the version of LavinMQ

@kickster97 kickster97 requested review from dentarg and walro April 29, 2024 10:48
@walro
Copy link
Contributor

walro commented Apr 30, 2024

Not really related to the service, but it looks like the formula can't be built, see annotations in https://github.com/cloudamqp/homebrew-cloudamqp/pull/13/files

Perhaps open a PR just changing the LavinMQ version and see if we can fix those problems?

@kickster97
Copy link
Member Author

Not really related to the service, but it looks like the formula can't be built, see annotations in https://github.com/cloudamqp/homebrew-cloudamqp/pull/13/files

Perhaps open a PR just changing the LavinMQ version and see if we can fix those problems?

ah, hadnt seen them bc the tests looked green :o
I changed it, but now it fails on the reason I updated the version in the same pr in the first place 😅

@walro
Copy link
Contributor

walro commented Apr 30, 2024

I changed it, but now it fails on the reason I updated the version in the same pr in the first place 😅

😅 let's bump version in separate PR and them rebase this one once we get it working

@walro walro force-pushed the lavinmq-service branch from f8b9834 to 655f297 Compare May 3, 2024 08:12
Formula/lavinmq.rb Outdated Show resolved Hide resolved
Formula/lavinmq.rb Show resolved Hide resolved
Co-authored-by: Robin Wallin <[email protected]>
@kickster97 kickster97 requested a review from walro May 3, 2024 12:39
@kickster97 kickster97 merged commit 0feea0b into main May 6, 2024
2 checks passed
@kickster97 kickster97 deleted the lavinmq-service branch May 6, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants