-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replication lag improvement #652
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
@kickster97 Hmm, I wonder if skipping for |
I think (hope) the CLA workflow behaves better now going forward. Closing/re-opening didn't really work as I expected, the workflow only ran on the close event: https://github.com/cloudamqp/lavinmq/actions/workflows/cla.yml?query=branch%3Areplication-lag-improvement – I unlocked this PR with the GitHub CLI and also created #654 |
This will also count all data that needs to be sent as lag, not only "message data" (i.e. it counts filename length etc too). |
Maybe it should be changed to only count message data. |
Is it not more accurate if we count all data? Why would we only want to count message data? |
It may not always represent the entire Action size sent over the socket.
e5aee74
to
8f30d5e
Compare
WHAT is this pull request doing?
Before this we only counted data written to the follower socket as lag, we didn't count the data in the "action queue" of the follower.
This will change so we count data written to the action queue.
HOW can this pull request be tested?
Run follower specs