MQTT-support #766
MQTT-support #766
Conversation
kickster97
force-pushed
the
mqtt-poc
branch
from
cb77ee8 to
7130ee3
Compare
|
I think you can (and maybe even should) build clean session by reusing the auto delete feature of queues. |
kickster97
force-pushed
the
mqtt-poc
branch
2 times, most recently
from
787840d to
4e747f2
Compare
|
About #803 (comment) That connect spec passes, but for the wrong reason. Or well, the socket is closed but not because it receives the wrong packet type, but because of the bug that #803 will fix. When that bug is fixed i still think that the spec will pass, but for the right reason. I guess the spec could be changed to send a |
|
After giving it a second thought I've concluded that we should change the spec to use some other packet type. |
ok I will change the spec then! thanks :) |
|
Often it's more efficient to |
| # This macro will find the "bind" method of classes inheriting from this class | ||
| # and redefine them to raise AccessRefused exception if the first argument | ||
| # isn't a type in LavinMQ::AMQP namespace. | ||
| # | ||
| # TODO remove this when LavinMQ::MQTT::Session no longer inherit from | ||
| # LavinMQ::AMQP::Queue and LavinMQ::MQTT::Exchange no longer inherit from | ||
| # lavinMQ::AMQP::Exchange |
There was a problem hiding this comment.
I call this black magic!
But the TODO note was a relief
There was a problem hiding this comment.
this can be done explicitly instead? can't be that many methods?
There was a problem hiding this comment.
The next step after merging would be to separate Session from Queue, so this is very temporary
|
please rebase, and squash as many commits as possible. |
kickster97
force-pushed
the
mqtt-poc
branch
2 times, most recently
from
76917ad to
bd762b2
Compare
Co-authored-by: Jon Börjesson <[email protected]>
WHAT is this pull request doing?
An MQTT-session inherits AMQP::Queue and extends with MQTT functionality.
MQTT exchange(topic) will only accept activity from an MQTT client, that will be responsible for routing messages to the MQTT-session.
The mqtt exchange handles MQTT routing keys etc. without needing to do conversions.
NOTE
The first version of MQTT Support does not support binding an AMQP exchange to and MQTT exchange. (Undefined behaviour if done)
In a separate PR we need to extract the AMQP exchange types into the AMQP namespace and in turn be able to differentiate between an
AMQP::Destinationand anMQTT::Destiantionwhen callingbind.With that in place we will be able to safely do exchange to exchange bindings.
Docs for the website
HOW can this pull request be tested?
Specs have been migrated from Myra and fully cover the MQTT protocol, run with crystal spec.
Connect with mqtt client library of your choice and test your usage against this branch