-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exit 5 instead of raising error if no etcd endpoint responds #886
Conversation
I did this for exit 3: 5fd0ea0 So it won't exit specs.. it's not pretty though :/ |
Did the same here for now 👍 IMO let's go with that solution until we figure out something better! |
I reverted that, exiting in code, if the code is running in a fiber nothing would rescue and exit it. |
Check if we can override |
Yes we can, just something like the following in
|
So we can just do:
But maybe it's worth defining a |
f50adde
to
cdfdbee
Compare
So that the errors can be caught in specs. In lavinmq.cr is the exit done
This reverts commit 4911532.
cdfdbee
to
3584853
Compare
WHAT is this pull request doing?
Exit 5 (5th letter, E, for etcd) instead of raising error when no etcd endpoint responds.
fixes #872
HOW can this pull request be tested?
Try starting LavinMQ with clustering enabled and no etcd running.