introduce auth_chain, abstract authenticator and the basic authenticator #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
force-pushed
the
authentication-chain
branch
from
fc4c424 to
0161b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
This is a preparatory step towards introducing multiple authentication backends, which can be tried and run on a chain of command. (It breaks up #861 so it dosn't become to large)
This PR introduces the basic authenticator, which entails the basic authentication method we already support.
These modules will be extended with oauth and http support in the future.
HOW can this pull request be tested?
Should probably write a spec for the chain,
but you can run the regular connect specs, and try to manually authenticate