Cleanup RabbitMQ configuration resource #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize the d.HasChange(key) to determine which resource arguments being changed. If no change detected at all (during initial create) don't make the API backend call.
dentarg
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create/Update
Both Create/Update only update the RabbitMQ config, re-use the update function for both of them. Also determine if any schema argument have been updated with
d.HasChange(k). Then only update changed arguments.Related to #214 Will still not work on initial resource create, due to to old Terraform Plugin SDK version. Not possible to detect schema argument using default values (e.g. string = "", int = 0). Since unset values cannot be represented as null and therefore are given default values.
Read
Updated read function to not set default configuration values for