Fix network preservation #357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dany9966
reviewed
Jun 25, 2025
coriolis/osmorphing/base.py
Outdated
| if ip in info["ip_addresses"] and mac_address: | ||
| net_ifaces_info[iface] = mac_address | ||
| elif ip_addresses: | ||
| LOG.info("Parsed nic info does not contain mac address") |
There was a problem hiding this comment.
NIT: Please capitalize NIC and MAC.
There was a problem hiding this comment.
You could also include the NIC name, so then you know which NIC this is about.
coriolis/osmorphing/base.py
Outdated
| net_ifaces_info[iface] = mac_address | ||
| elif ip_addresses: | ||
| LOG.info("Parsed nic info does not contain mac address") | ||
| LOG.info("<templog>Ip adresses: %s", |
There was a problem hiding this comment.
Was this intended to be just a testing log?
Cristi1324
force-pushed
the
fix-net-preservation
branch
from
857d0d7 to
59cc2ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.