Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL filter: Clarify that only boolean TRUE values pass filter #1243

Merged
merged 1 commit into from
Oct 26, 2023
Merged

SQL filter: Clarify that only boolean TRUE values pass filter #1243

merged 1 commit into from
Oct 26, 2023

Conversation

Cali0707
Copy link
Contributor

Fixes #1221

Proposed Changes

  • Only CESQL results which are the TRUE boolean value should pass the filter.

Release Note

Only CESQL results which are equal to the `TRUE` boolean value pass the CESQL subscriptions API filter.

@duglin
Copy link
Collaborator

duglin commented Oct 25, 2023

LGTM
@lionelvillard any thoughts?
@jskeet too

@jskeet
Copy link
Contributor

jskeet commented Oct 25, 2023

Yup, that works for me, personally - as someone who's never used CloudEvents SQL at all!

@duglin
Copy link
Collaborator

duglin commented Oct 26, 2023

Approved on the 10/26 call

@duglin duglin merged commit a7f82aa into cloudevents:main Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql filter: clarification of non-boolean cesql expression result coercion to a boolean
3 participants
@Cali0707 @duglin @jskeet