Skip to content

Fix the description of --keep-vars #22386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

Fix the description of --keep-vars #22386

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented May 13, 2025

Summary

Bindings are always overriden when --keep-vars is used or not.

Also clarify that secrets are never deleted.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions github-actions bot added the product:workers Related to Workers product label May 13, 2025
Copy link
Contributor

hyperlint-ai bot commented May 13, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Clarified the behavior of the --keep-vars option in the documentation, emphasizing that bindings are always overridden and that secrets are never deleted during deployment.

  • Updated the description of the --keep-vars option to clarify its behavior regarding bindings.
  • Specified that secrets are never deleted by a deployment, regardless of the --keep-vars flag.

Modified Files

  • src/content/docs/workers/wrangler/commands.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@vicb vicb marked this pull request as ready for review May 13, 2025 12:15
@vicb vicb requested review from irvinebroque, ToriLindsay and a team as code owners May 13, 2025 12:15
Copy link
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/workers/wrangler/ @cloudflare/wrangler, @irvinebroque, @ToriLindsay, @cloudflare/pcx-technical-writing

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants