Modernize example with support for ES Modules #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These improve performance, while also making it easy to turn off build performance features for troubleshooting
A plain Javascript entrypoint is necessary to then launch the Kotlin/JS application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the Kotlin Cloudflare Worker example in several ways:
worker-integration-testfor the test cases. (Note that the integration tests are in a separate module instead ofworker-app/jsTest, because worker-app uses the Kotlin browser target to enable Kotlin packaging tasks, while Miniflare requires the nodejs target)These changes could be broken into independent pull requests in top-to-bottom order, although they'd need to be created one at a time due to later changes depending on earlier changes. Let me know if that would be preferred.