Bigint Migration for 'events' Table (Step 1) #4281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
force-pushed
the
bigint-migration-events-step1
branch
13 times, most recently
from
a0ee2b7 to
d37b9fa
Compare
3 tasks
philippthun
force-pushed
the
bigint-migration-events-step1
branch
from
d37b9fa to
f3d6fe9
Compare
philippthun
changed the title
philippthun
force-pushed
the
bigint-migration-events-step1
branch
from
f3d6fe9 to
51e2109
Compare
philippthun
force-pushed
the
bigint-migration-events-step1
branch
3 times, most recently
from
4aaae49 to
6d05889
Compare
philippthun
force-pushed
the
bigint-migration-events-step1
branch
from
6d05889 to
e6bb19a
Compare
philippthun
force-pushed
the
bigint-migration-events-step1
branch
3 times, most recently
from
e3b2c4e to
2cca5b8
Compare
johha
previously approved these changes
May 5, 2025
philippthun
force-pushed
the
bigint-migration-events-step1
branch
from
2cca5b8 to
c446ca8
Compare
- reusable module VCAP::BigintMigration - implementation of step 1 (the events' primary key is not used as foreign key, thus additions will be required when reusing this for other tables) - check database type (PostgreSQL only) - check opt-out flag - check if table is empty - change primary key to bigint directly, if table is empty - add bigint column and create trigger + function otherwise - reusable shared_context for tests - ADR adapted (PostgreSQL only) - Rake task db:bigint_backfill to manually trigger a backfill (optional)
philippthun
force-pushed
the
bigint-migration-events-step1
branch
from
c446ca8 to
9eb51d4
Compare
johha
approved these changes
May 5, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 5, 2025
Changes in cloud_controller_ng:
- Bigint Migration for 'events' Table (Step 1)
PR: cloudfoundry/cloud_controller_ng#4281
Author: Philipp Thun <[email protected]>
sethboyles
pushed a commit
that referenced
this pull request
May 5, 2025
- reusable module VCAP::BigintMigration - implementation of step 1 (the events' primary key is not used as foreign key, thus additions will be required when reusing this for other tables) - check database type (PostgreSQL only) - check opt-out flag - check if table is empty - change primary key to bigint directly, if table is empty - add bigint column and create trigger + function otherwise - reusable shared_context for tests - ADR adapted (PostgreSQL only) - Rake task db:bigint_backfill to manually trigger a backfill (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VCAP::BigintMigrationdb:bigint_backfillto manually trigger a backfill (optional)Related PR: cloudfoundry/capi-release#533
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests