Skip to content

Document use of Cloud Native Buildpacks #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

c0d1ngm0nk3y
Copy link
Contributor

@c0d1ngm0nk3y c0d1ngm0nk3y commented Sep 20, 2024

Preview: https://cnb-docs-preview.cfapps.sap.hana.ondemand.com/buildpacks

Note that the content of this page changes!

part-of: #310

@pspinrad
Copy link
Contributor

pspinrad commented Sep 20, 2024

Hi @c0d1ngm0nk3y -- good idea to create a sub-level for buildpacks in the table of contents, but it would cause trouble to move all the source files themselves down a level, because they're linked to from lots of other places in the CF docs and elsewhere on the web, so all of those URLs would no longer work.
WDYT would be a good strategy for adding Cloud Native buildpack pages without messing with existing file structure? /cnb subdirectory, or cnb filename prefix or suffix?
Re: terminology, in the Tanzu docs, for example this page, we're using terminology "Cloud Foundry buildpacks" and "Cloud Native buildpacks" to differentiate between the older and newer buildpack types. "Classical" here refers to the CF buildpacks in that terminology, right?

@c0d1ngm0nk3y c0d1ngm0nk3y marked this pull request as ready for review September 30, 2024 12:49
@c0d1ngm0nk3y c0d1ngm0nk3y force-pushed the cnb-docu branch 2 times, most recently from 2cb75ef to fe08f0d Compare October 16, 2024 08:51
@pspinrad
Copy link
Contributor

Hi @c0d1ngm0nk3y -- thanks for your continued work on this. I'm not merging yet here or in docs-book-cloudfoundry because the build pipeline is still broken, sorry for delay! Once that's fixed, can publish all this great new stuff and verify that it all works.

owner: Buildpacks
---

You can the [paketo](https://paketo.io/) buildpacks as one implementaion of Cloud Native Buildpacks. You will find buildpacks for the most popular languages, like

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo:

Suggested change
You can the [paketo](https://paketo.io/) buildpacks as one implementaion of Cloud Native Buildpacks. You will find buildpacks for the most popular languages, like
You can use the [paketo](https://paketo.io/) buildpacks as one implementation of Cloud Native Buildpacks. You will find Paketo buildpacks for the most popular languages, like

<code>cf push APP-NAME --lifecycle cnb -b docker://FIRST-BUILDPACK -b docker://SECOND-BUILDPACK</code>
```

In this case <em>all</em> buildpacks must `detect` and `build` is called in the given order.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this case <em>all</em> buildpacks must `detect` and `build` is called in the given order.
In this case <em>all</em> buildpacks must run `detect` and `build` in the given order.

@anthonydahanne
Copy link

@pivotal-david-osullivan apparently I don't have approving rights here; could you please approve?
I've reviewed it, just few typos to fix
Thanks!

@pspinrad pspinrad merged commit 072cc00 into cloudfoundry:master Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants