Use named parameters when constructing structs

cloudfoundry · Sep 7, 2023 · 13dde82 · 13dde82
1 parent 51e06f3
commit 13dde82
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/commandparser/construct_test.go b/commandparser/construct_test.go
@@ -150,7 +150,7 @@ var _ = Describe("construct", func() {
 
 		BeforeEach(func() {
 			f = flag.NewFlagSet("test", flag.ExitOnError)
-			gf = &commandparser.GlobalFlags{false, false, false}
+			gf = &commandparser.GlobalFlags{}
 
 			fakeFactory = &commandparserfakes.FakeVMPreparerFactory{}
 			fakeVmConstruct = &commandparserfakes.FakeVmConstruct{}

diff --git a/commandparser/package_messenger_test.go b/commandparser/package_messenger_test.go
@@ -18,7 +18,7 @@ var _ = Describe("PackageMessenger", func() {
 
 	BeforeEach(func() {
 		buf = gbytes.NewBuffer()
-		messenger = &commandparser.PackageMessenger{buf}
+		messenger = &commandparser.PackageMessenger{Output: buf}
 	})
 
 	It("writes the error message to the write when InvalidOutputConfig is called", func() {

diff --git a/commandparser/package_stemcell_test.go b/commandparser/package_stemcell_test.go
@@ -42,7 +42,7 @@ var _ = Describe("package_stemcell", func() {
 
 			PkgCmd = commandparser.NewPackageCommand(oSAndVersionGetter, packagerFactory, packagerMessenger)
 			PkgCmd.SetFlags(f)
-			PkgCmd.GlobalFlags = &commandparser.GlobalFlags{false, false, false}
+			PkgCmd.GlobalFlags = &commandparser.GlobalFlags{}
 		})
 
 		var defaultArgs = []string{}