Fix Makefile build target #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since tar.exe, bosh-blobstore-s3.exe, bosh-blobstore-dav.exe were (correctly) removed from the BOSH agent repository this had the unfortunate side effect of breaking the stembuild make build target. The latest dependencies to build StemcellAutomation.zip are now downloaded from their respective s3 buckets that the official stembuild CI system uses.
rkoster
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Could you also add a link to installation instructions for xq to the README somewhere around here: https://github.com/cloudfoundry/stembuild/blob/master/README.md#testing
rkoster
requested review from
a team,
bgandon,
danielfor and
jpalermo
and removed request for
a team
|
Lint errors fixed on primary branch bbb4bb1 |
- Add dependencies required like xq - Update and simplify the example `make build` command
|
@rkoster I updated the local build instructions to mention |
ystros
reviewed
Mar 1, 2024
- Fix sorting and tool selection to use latest versions
|
@ystros I fixed the couple of issues you noted. I also fixed one I noticed where xq wasn't returning the latest s3 key. |
ystros
approved these changes
Mar 15, 2024
rkoster
approved these changes
Mar 15, 2024
|
Thanks! @sneal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add targets that download StemcellAutomation.zip dependencies from s3 to unblock local development of stembuild.
Since tar.exe, bosh-blobstore-s3.exe, bosh-blobstore-dav.exe were removed from the BOSH agent repository this had the unfortunate side effect of breaking the stembuild make build target. The latest dependencies to build StemcellAutomation.zip are now downloaded from their respective s3 buckets that the official stembuild CI system uses.
The targets do require the use of
xq(wrapper around jq that handles xml) to select the latest version of each dependencies in each s3 bucket.